From: hooanon05@yahoo.co.jp
To: iet-dev <iscsitarget-devel@lists.sourceforge.net>
Subject: two minor bugs around a parameter
Date: Thu, 16 Jun 2005 02:14:55 +0900


two minor bugs.
- checking target_type_array index, in kernel.
- intializing the 'Type' parameter range, in user.


Junjiro Okajima


Index: kernel/param.c
===================================================================
RCS file: /ext1/iscsi/repository/iet-0.4.10/kernel/param.c,v
retrieving revision 1.4
diff -u -r1.4 param.c
--- kernel/param.c	15 Jun 2005 09:33:03 -0000	1.4
+++ kernel/param.c	15 Jun 2005 17:03:13 -0000
@@ -113,7 +113,7 @@
 
 	CHECK_PARAM(info, iparam, wthreads, MIN_NR_WTHREADS, MAX_NR_WTHREADS);
 	CHECK_PARAM(info, iparam, target_type, 0,
-		    (unsigned int) ARRAY_SIZE(target_type_array));
+		    (unsigned int) ARRAY_SIZE(target_type_array)-1);
 	CHECK_PARAM(info, iparam, queued_cmnds, MIN_NR_QUEUED_CMNDS, MAX_NR_QUEUED_CMNDS);
 }
 
Index: iet-0.4.10/usr/param.c
diff -u iet-0.4.10/usr/param.c:1.1 iet-0.4.10/usr/param.c:1.2
--- iet-0.4.10/usr/param.c:1.1	Sat Jun 11 11:30:57 2005
+++ iet-0.4.10/usr/param.c	Sat Jun 11 11:44:09 2005
@@ -285,7 +285,7 @@
 
 struct iscsi_key target_keys[] = {
 	{"Wthreads", SET_KEY_VALUES(WTHREADS), &minimum_ops},
-	{"Type", 0, 16, 0, &minimum_ops},
+	{"Type", 0, 0, 16, &minimum_ops},
 	{"QueuedCommands", SET_KEY_VALUES(QUEUED_CMNDS), &minimum_ops},
 	{NULL,},
 };